-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deep merge fetch options #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 86.76% 90.32% +3.56%
==========================================
Files 5 5
Lines 423 455 +32
Branches 67 73 +6
==========================================
+ Hits 367 411 +44
+ Misses 56 44 -12
|
pi0
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a fetch instance is created with default header options, and that instance is then called with more headers the default headers are overwritten. The same goes for the
param
andquery
properties.The outgoing request should have both the
Header-Request
andHeader-Default
headers, but will only contain the former.Fix
Merging the
headers
,params
andquery
properties of theFetchOptions
object before fetching fixes this issue. A more generic deep merge approach was tried, but merging other properties such as the body makes little sense.