-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental support for deno v2 #158
Conversation
Co-authored-by: Horu <[email protected]>
@@ -29,6 +29,7 @@ export async function installDependencies( | |||
yarn: ["install", "--immutable"], | |||
bun: ["install", "--frozen-lockfile"], | |||
pnpm: ["install", "--frozen-lockfile"], | |||
deno: ["install", "--frozen"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Deno doesn't run lifecycle scripts by default, should we include the --allow-scripts
flag in the command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhmm i genuinely don't know what's the best option here @pi0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point however as per docs:
Note: Scripts will only be executed when using a node_modules directory (--node-modules-dir).
So I'm not sure either. I would say let's iterate and see if we need it in practice.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for nice work on this ❤️
This PR adds support for
deno
. As Deno supports reading frompackage.json
the only real differences are the following:npm:
prefix to dependencies that do not already have one to align with the behavior of other package managers;deno
as the package manager if adeno.json
file is present in the root folder sincedeno
is not a valid entry in thepackageManager
property ofpackage.json
(if nodeno.json
file is present but adeno.lock
is, nypm is still able to detect it).resolves #157.