Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Thanks for the project, it has been of great help for my own project: https://github.com/LekoArts/secco
I've found a small bug in this codepath:
The comparison of
pm.majorVersion === majorVersion
will currently be3.0.0 === 3
, so it'll fall back to the first name found. So if you e.g. run the detection in a yarn berry project you won't get back thefiles
array.In 3b0f0aa I added the assertion of
files
to the tests, which then were failing. The commit after that fixes it.I'll leave some inline comments that we could consider for future PRs but I wanted to discuss first.