Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxy): merge overriden headers with different case #476

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 1, 2023

πŸ”— Linked issue

Resolves #450

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When custom proxy headers are configured, they should override regardless of casing differences. This PR does this by introducing an internal util leveraging Headers object.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(proxy): properly merge overriden headers fix(proxy): merge overriden headers with different case Aug 1, 2023
@pi0 pi0 marked this pull request as ready for review August 1, 2023 11:37
@pi0 pi0 merged commit 4de6335 into main Aug 1, 2023
4 checks passed
@pi0 pi0 deleted the fix/proxy-header branch August 1, 2023 11:42
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxyRequest() doesn't take into account header casing when overriding headers.
1 participant