fix: keep backward compatibility with event.node.req.url
#471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
(failing tests against nuxt)
β Type of change
π Description
This PR adds backward compatibility to the changes in #438 for
event.path
support. While we ideally could benefit from a single and normalized getter, it makes issues on edge cases when we are depending on legacy express like behavior (nuxt vite intention) to allow:/module/@fs//...
)event.node.req.url
directlyBecause of this, this PR reverts
event.path
behavior to prefer future_path
prop if exists and otherwise return (not normalized)node.req.url
and also preservesnode.req.originalPath
Also to avoid issues with same tick modification, app handler directly reads from
event.node.req.url
without depending on getter which strangely keeps failing when using getter.π Checklist