fix(proxy): transparently forward errors when passing ofetch

[Aareksio]

🔗 Linked issue

#464

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As discussed in #464 and nitrojs/nitro#1489.

ProxyOptions type updated to allow overriding the default value (true).

---

Is it breaking change?

I would say so, users may depend on error masking. This is not strictly a bug. Mandatory xkcd: https://xkcd.com/1172/

---

I personally dislike this solution a lot; if we allow freedom of passing fetch implementation, it should be up to the callee to configure the behavior of their implementation exactly as they like. If it's required to pass option to do so, they already can do so with fetchOptions.

Forcing ignoreResponseError: true is implicitly re-configuring non-default user-passed implementation. I think better approach is to allow the freedom along with passing the responsibility. Another edge-case is when user passes fetch implementation which also supports ignoreResponseError or throws on unknown parameters - both sound plausible to me.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pi0]

I personally dislike this solution a lot; if we allow freedom of passing fetch implementation, it should be up to the callee to configure the behavior of their implementation exactly as they like. If it's required to pass option to do so, they already can do so with fetchOptions.

I think both implementation can be changed and also this option can be directly still overridden by users.

I consider it as a good fix because the h3 intended behavior was transparently bypassing. It was mainly my bad that forgot about it when integrating with nitr. (reason of using ofetch was direct calls not hiding them)

[Aareksio]

Either solution solves the problem. If you like it, that's good enough! Much better title too! ❤️

I am still a little worried about this one guy who uses error masking to hide secrets from consumers, but if you consider it non breaking, be it 😂

[pi0]

You can try it on nightly channel now (check little new section in readme!)