fix(event): do not remove double slashes from query #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#463
(also see added test case)
β Type of change
π Description
Currently the regex replaces all occurrences of multiple
/
with a single/
. This is desired, but only for thepath
, notquery
part of the URL. This PR ensures the replacement is only done to the part of path coming before?
. There is noufo
helper for extracting just the path nor for detecting if path includes query - therefore I have used good old.includes('?')
and.split('?')
.There is cleanDoubleSlashes available in ufo, but it seems to suffer from the same issue. May be worth fixing there and updating h3 to use ufo helper.
Resolves #463
π Checklist