-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event): event.request
getter to access web request
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
feat:
feat(event): Jul 24, 2023
event.request
to return a web requestevent.request
getter to access web request
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 77.93% 78.23% +0.29%
==========================================
Files 26 26
Lines 2724 2775 +51
Branches 398 407 +9
==========================================
+ Hits 2123 2171 +48
- Misses 601 604 +3
|
8 tasks
This was referenced Jul 24, 2023
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#73
β Type of change
π Description
This PR adds support for the lazy initialized
event.request
property that resolves to a standard Web Request.Note: It is still highly recommended to prefer using top level event API (
event.{path,method,headers}
) as it has lower foot print and can be optimized per runtime platform.Known issues: Node.js 16 does not supports ReadableStream as body for Request constructor
Thanks for the initiative ideas from @Hebilicious in #421
π Checklist