Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): explicitly import the URL type #3

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix(types): explicitly import the URL type #3

merged 1 commit into from
Nov 26, 2020

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Nov 26, 2020

What's the problem this PR addresses?

The URL type isn't explicitly imported which means people without skipLibCheck: true needs to add DOM to their lib config

Fixes cucumber/cucumber-js#1413 (comment)

How did you fix it?

Explicitly import the URL type

@merceyz merceyz mentioned this pull request Nov 26, 2020
Merged
@pi0 pi0 changed the title fix: explicitly import the URL type fix(types): explicitly import the URL type Nov 26, 2020
@pi0 pi0 merged commit 66a98cc into unjs:master Nov 26, 2020
@merceyz merceyz deleted the patch-1 branch November 26, 2020 13:40
@pi0
Copy link
Member

pi0 commented Nov 26, 2020

Thanks. Released https://github.com/nuxt-contrib/create-require/releases/tag/v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @pi0