Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial server skeleton #9

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhiaagarwal
Copy link
Collaborator

Contains the initial skeleton for server code. Only does routing, the business logic are left purposefully empty.

The goal with the Utoipa annotations is to have docs+code in the same place and to eventually host a swagger UI built as part of the build process.

@abrassel
Copy link
Collaborator

This looks like a great approach! Before we move forward, I'd like to reach a conclusion about where and how we will build our data models.

If we use prost to generate them from protobuf, I would prefer we migrate the models before we depend on them in the server.

@abhiaagarwal
Copy link
Collaborator Author

@abrassel absolutely, let me mark as a draft until we have a more concrete plan

@abhiaagarwal abhiaagarwal marked this pull request as draft June 20, 2024 05:39
@roeap
Copy link

roeap commented Jul 7, 2024

If we use prost to generate them from protobuf

Personally I am a big fan of protobuf to generate types, and it seems mlflow and others do this too. Right now I am re-writing delta-sharing-rs to take the same approach.

This is actually how I ended up here, since we have a need for a catalog api there as well and I wanted it to loom similar. So in case there is any help wanted in getting some protobuf type generation started - happy to help :).

@abrassel
Copy link
Collaborator

abrassel commented Jul 7, 2024

Hey @roeap ! Id recommend checking out the discussion we have open on this topic. I'm personally also partial to protobuf generation. If you wanted to write the protobuf definition it would be very helpful for the rust client I'm currently working on.

Do we have an existing protobuf definition in any of the sister projects?

@roeap
Copy link

roeap commented Jul 7, 2024

@abrassel - thanks, will do!

speaking of clients, I just opened #15 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants