Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented telnet TM option #135

Open
wants to merge 2 commits into
base: feat/telnet-eor
Choose a base branch
from

Conversation

mystiker
Copy link
Collaborator

Description

This PR introduces support for the Telnet TIMING-MARK (TM) option, enabling synchronization points in the data stream as described in RFC 860. The feature allows the client to handle TIMING-MARK requests while involving the frontend in the acknowledgment process.

How It Works

Server Request:

  • When the Telnet server sends a WILL TIMING-MARK, the client does not immediately respond with DO.

Frontend Acknowledgment:

  • The client emits a requestTimingMark event to the frontend, signaling the need to acknowledge the TIMING-MARK request.
  • he frontend confirms the request through a built-in callback.

Response to Server:

  • Once the frontend acknowledges the requestTimingMark, the client sends a DO TIMING-MARK to the Telnet server, completing the negotiation process.
  • This approach allows for greater control over TIMING-MARK handling by involving the frontend in the acknowledgment flow, ensuring synchronization requirements are met effectively.

Changes

  • Added a requestTimingMark event to notify the frontend of TIMING-MARK requests from the server.
  • Implemented a callback mechanism to handle frontend acknowledgment before sending the final DO to the server.

Fixes #129

@mystiker mystiker self-assigned this Nov 23, 2024
@mystiker mystiker linked an issue Nov 23, 2024 that may be closed by this pull request
@mystiker mystiker force-pushed the feat/telnet-timing-mark branch from e862989 to fed2f44 Compare November 23, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Telnet TIMING-MARK Option
1 participant