Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov for testing code coverage in the CI #301

Merged
merged 9 commits into from
Aug 14, 2020
Merged

Add Codecov for testing code coverage in the CI #301

merged 9 commits into from
Aug 14, 2020

Conversation

karalekas
Copy link
Member

@karalekas karalekas commented Aug 14, 2020

Adds Codecov to the CI. Was originally planning on using Coveralls (#299) but then I read this: coverallsapp/github-action#30. Related to #268. Might need to move the coverage-related step to its own job so it's not run thrice by build matrix.

@karalekas karalekas added this to the Alpha v4 milestone Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5a1e346). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #301   +/-   ##
=========================================
  Coverage          ?   90.66%           
=========================================
  Files             ?       17           
  Lines             ?      868           
  Branches          ?        0           
=========================================
  Hits              ?      787           
  Misses            ?       81           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1e346...0d1f5a9. Read the comment docs.

@karalekas karalekas self-assigned this Aug 14, 2020
Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed it was more integrated with Travis CI as I switched on Coveralls for the repo, but hoped it would be integrated by default. Looks nice to me with Codecov, also not adding builds or steps in CI.

I am not sure of how to read that colored graph at the end.

@karalekas karalekas merged commit b9c68c2 into master Aug 14, 2020
@karalekas karalekas deleted the codecov branch August 14, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants