Complete LRE user guide #2542
Merged
Complete LRE user guide #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 92 92
Lines 4161 4167 +6
=======================================
+ Hits 4108 4114 +6
Misses 53 53 ☔ View full report in Codecov by Sentry. |
purva-thakre
force-pushed
the
lre_complete_guide
branch
from
6fa56af to
57bd891
Compare
|
For some reason, the RTD build is taking longer than 45-50 mins. |
|
@natestemen This PR is still in draft status due to part 4 of the user guide. I pinged you so that you could review what's already in this PR. |
vprusso
reviewed
Oct 23, 2024
natestemen
requested changes
Oct 30, 2024
| def _get_scale_factor_vectors( | ||
| def get_scale_factor_vectors( |
There was a problem hiding this comment.
Reminder to myself that I will need to convert this function to allow for arbitrary QPROGRAM.
Co-authored-by: nate stemen <[email protected]>
natestemen
reviewed
Nov 4, 2024
Co-authored-by: nate stemen <[email protected]>
natestemen
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #2371
Merge after #2541
License
Before opening the PR, please ensure you have completed the following where appropriate.