Clean & document dependencies #69
Conversation
| @@ -33,6 +33,8 @@ jobs: | |||
|
|
|||
| - name: "5. Install main and dev dependencies" | |||
| run: | | |||
| # this avoids an unnecessary cuda install on Linux | |||
There was a problem hiding this comment.
Do you think we can put it in some requirements?
There was a problem hiding this comment.
nope, see PR:
- easy install steps for all envs
- need fbprophet to 0.6 because they fix an easter 'egg' (facebook/prophet#1300)
- make sure CI uses non-cuda torch
Ideally, we would just add per-OS requirements in requirements.txt, e.g.
torch==1.6.0+cpu -f https://download.pytorch.org/whl/torch_stable.html; platform_system == "Windows"but -f does not seem to work inside requirements.txt atm (pypa/pip#8103)
| and [torch](https://pytorch.org/get-started/locally/), then skip to | ||
| [Install u8timeseries](#install-u8timeseries) | ||
|
|
||
| To create a conda environment for Python 3.7 |
There was a problem hiding this comment.
I would put 3.6 as it is our min requirement.
There was a problem hiding this comment.
sure, though it's just an example for users that never used conda
| conda install -c conda-forge -c pytorch pip fbprophet pytorch cpuonly | ||
|
|
||
| ## Install u8timeseries | ||
| pip install u8timeseries |
There was a problem hiding this comment.
Running only this one out-of-the-box in a non-conda virtualenv doesn't work?
There was a problem hiding this comment.
Nope, because of the non-Python platform-specific stuff, in this case fbprophet (and indirectly pystan) and possibly more.
Essentially everything in the Dockerfile is needed (plus whatever is in the FROM image) and Conda handles it.
Ideally, we would just add per-OS requirements in requirements.txt, e.g.
but -f does not seem to work inside requirements.txt atm (pypa/pip#8103)