allow threads to die with ExitSuccess without printing a message #5548
+28
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR just whitelists
ExitSuccess
so that background threads that unexpectedly die withExitSuccess
don't cause a message likeThis isn't an awesome solution – throwing
ExitSuccess
from a background thread isn't an established practice or anything. But we simply don't have control over these threads, since they're deep within thelsp
library.A better solution would be to patch
lsp
to have better thread hygiene, but this solution is a one-liner and seems pragmatic, for now.Test coverage
I tested this change manually
--
closes #4737