Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow threads to die with ExitSuccess without printing a message #5548

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mitchellwrosen
Copy link
Member

@mitchellwrosen mitchellwrosen commented Jan 17, 2025

Overview

This PR just whitelists ExitSuccess so that background threads that unexpectedly die with ExitSuccess don't cause a message like

Uh oh, an unexpected exception brought the process down! That should never happen. Please file a bug report.

Here's a stringy rendering of the exception:

  ExitSuccess

This isn't an awesome solution – throwing ExitSuccess from a background thread isn't an established practice or anything. But we simply don't have control over these threads, since they're deep within the lsp library.

A better solution would be to patch lsp to have better thread hygiene, but this solution is a one-liner and seems pragmatic, for now.

Test coverage

I tested this change manually

--
closes #4737

@aryairani aryairani merged commit 14c73f1 into trunk Jan 17, 2025
32 checks passed
@aryairani aryairani deleted the no-ExitSuccess-message branch January 17, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected ExitSuccess exception "brought the process down"?
2 participants