Add-instace-support #157
Add-instace-support #157
Conversation
This commit add an instance support for TACL. You can user instances with api_key for a client that is allowed instances authentication example: tacl p11 --api-key <api_key> --link-id <> --upload myfile
|
Triggered from #157 by @kouylekov-usit. Checking if we can fast forward Target branch ( commit d306615f6d8c8b8f280d0f8308bfff6019d8952b (HEAD -> master, origin/master, origin/HEAD)
Author: Eirik Haatveit <[email protected]>
Date: Tue Sep 17 15:25:18 2024 +0200
Revert "ci(docs): add automatic generation of CHANGELOG"
This reverts commit 32e2558c3ef77ab8da335b42134533697d5c3938.
As the commits generated by CI fail branch protection rules, this will
have to wait until we figure out a good pattern for allowing automated
PR generation and merging of changelog updates.Pull request ( commit 07318449910be4dae7c22902694c348f8835f930 (pull_request/add-instace-support)
Author: Milen Kouylekov <[email protected]>
Date: Thu Oct 24 16:39:24 2024 +0200
feat: Add instance support to tacl
This commit add an instance support for TACL. You can user instances
with api_key for a client that is allowed instances authentication
example:
tacl p11 --api-key <api_key> --link-id <> --upload myfileIt is possible to fast forward |
|
Triggered from #157 by @kouylekov-usit. Checking if we can fast forward Target branch ( commit d306615f6d8c8b8f280d0f8308bfff6019d8952b (HEAD -> master, origin/master, origin/HEAD)
Author: Eirik Haatveit <[email protected]>
Date: Tue Sep 17 15:25:18 2024 +0200
Revert "ci(docs): add automatic generation of CHANGELOG"
This reverts commit 32e2558c3ef77ab8da335b42134533697d5c3938.
As the commits generated by CI fail branch protection rules, this will
have to wait until we figure out a good pattern for allowing automated
PR generation and merging of changelog updates.Pull request ( commit fb2fe5cd13727fc9c81edf0b73dd4f5221a843f8 (pull_request/add-instace-support)
Author: Milen Kouylekov <[email protected]>
Date: Fri Oct 25 15:38:51 2024 +0200
Add support for remote-path in uploads and downloadsIt is possible to fast forward |
| if match:=re.compile(patten).match(link_id): | ||
| link_id = uuid.UUID(match.group("link_id")) | ||
| if match.group("instance_type") == "c" and not secret_challenge: | ||
| click.echo("instance authentication requires a secret challenge") |
There was a problem hiding this comment.
We could consider interactively asking for the secret here
| @click.option( | ||
| '--remote-path', | ||
| required=False, | ||
| help='Specify a path on the remote server to upload' |
There was a problem hiding this comment.
Isn't it for both upload and download?
| '--secret-challenge', | ||
| required=False, | ||
| default=None, | ||
| help='Pass a secret challenge for instance authentication' |
There was a problem hiding this comment.
I think we should insist on passing it via a file here, to avoid it being in the PID list
This commit add an instance support for TACL. You can user instances
with api_key for a client that is allowed instances authentication
example:
tacl p11 --api-key <api_key> --link-id <> --upload myfile
This pull request resolves #104