New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input field names should be case insensitive #76

Closed

oyvindhagberg opened this issue Jan 15, 2019 · 0 comments

Labels

bug

Milestone

Production ready

Contributor

oyvindhagberg commented Jan 15, 2019

The input field names for all API methods should be case insensitive.

It should already work for GET requests: unpackFieldParam uses strings.EqualFold
Must test PUT/POST for all endpoints
Also, use req.PostFormValue instead of req.FormValue in all PUT/POST-handlers
The problem is that (Post)FormValue is case-sensitive. Get around it by calling req.ParseForm and make a custom method that searches the req.PostForm map. See api_keys.go

oyvindhagberg added the bug label

oyvindhagberg added this to the Production ready milestone

oyvindhagberg added a commit that referenced this issue


          Make input parameter names case insensitive

0d3d73f

Closes #76

oyvindhagberg mentioned this issue

Make input parameter names case insensitive #83

Merged

oyvindhagberg closed this as completed in #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment