Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostlist API must respect ACL when grouping #62

Closed
oyvindhagberg opened this issue Dec 10, 2018 · 2 comments · Fixed by #69
Closed

hostlist API must respect ACL when grouping #62

oyvindhagberg opened this issue Dec 10, 2018 · 2 comments · Fixed by #69
Assignees
@oyvindhagberg
Labels
bug question
Milestone
Public beta

Comments

@oyvindhagberg
Copy link
Contributor

oyvindhagberg commented Dec 10, 2018 •
edited
Loading

Seems like it might be easier if the ACL was in a database table, so queries could JOIN against it. Consider it before implementing anything. It would affect how LIMIT/OFFSET is done.

Edit: Putting the ACL in the database has been considered, and will be solved at a later time. The issue for that is #67.
@oyvindhagberg oyvindhagberg added this to the Public beta milestone Dec 10, 2018
@oyvindhagberg oyvindhagberg self-assigned this Dec 10, 2018
@oyvindhagberg
Copy link
Contributor Author

oyvindhagberg commented Dec 10, 2018 •
edited
Loading

  • Make a unit test that detects this bug

@oyvindhagberg oyvindhagberg mentioned this issue Dec 11, 2018
Closed
@oyvindhagberg oyvindhagberg added bug and removed API labels Dec 11, 2018
@oyvindhagberg
Copy link
Contributor Author

Can be easily solved in api_hostlist.go at line 364, pseudocode:

If not admin:
WHERE ... AND certfp IN ( all the certs from the accessprofile )

oyvindhagberg added a commit that referenced this issue Dec 12, 2018
@oyvindhagberg
Fix bug in hostlist API: Use ACL when grouping
5d90e64 
Fixes #62.
Also, a few other minor fixes (see diff)
@oyvindhagberg oyvindhagberg mentioned this issue Dec 13, 2018
Merged
oyvindhagberg added a commit that referenced this issue Dec 13, 2018
@oyvindhagberg
Fix bug in hostlist API: Use ACL when grouping (#69)
632f5df 
Fixes #62.
Also, a few other minor fixes (see diff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyvindhagberg oyvindhagberg

Labels
bug question
Projects
None yet
Milestone
Public beta
Development

Successfully merging a pull request may close this issue.

Fix bug in hostlist API: Use ACL when grouping unioslo/nivlheim
1 participant
@oyvindhagberg