Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add command completion descriptions #335

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Re-add command completion descriptions #335

merged 2 commits into from
Nov 20, 2024

Conversation

pederhan
Copy link
Member

@pederhan pederhan commented Nov 20, 2024 •
edited
Loading

This reverts the "fix" applied in #309 . I have no idea how to make the host and help completions render vertically, when permission and policy already do so by default.

terjekv
terjekv approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@terjekv terjekv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pederhan pederhan merged commit 535f6e3 into unioslo:master Nov 20, 2024
6 checks passed
@pederhan pederhan deleted the re-add-completion-description branch November 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terjekv terjekv terjekv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pederhan @terjekv