Remove zone serialnumber from test output. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
terjekv
commented
Dec 11, 2023
•
terjekv
commented
- When the serial number for zones is created (https://github.com/unioslo/mreg/blob/master/mreg/utils.py#L78) it is created as a "10-digit serialnumber in 3YYMMDDXXX format".
- It's hard to mock this as it comes from the server and it's not like we're in a pytest environment with the ci runs here.
- We would need to say something like "run this entire cli session as if the date and time was as follows", and outside of modifying the cli itself (it's an insane thing to offer as an option), we'd have to modify the runtime environment (ie, the container), but that would break SSL and its friends...
- So, in short, we remove Serialnumber from the test output...
- When the serial number for zones is created (https://github.com/unioslo/mreg/blob/master/mreg/utils.py#L78) it is created with as a "10-digit serialnumber in 3YYMMDDXXX format". - It's hard to mock this as it comes from the server and it's not like we're in a pytest environment with the ci runs here. - We would need to say something like "run this entire cli session as if the date and time was as follows", and outside of modifying the cli itself (it's an insane thing to offer as an option), we'd have to modify the runtime environment (ie, the container), but that would break SSL and its friends... - So, in short, we remove Serialnumber from the test output...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.