Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle unquoted pipes. #180

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

terjekv
Copy link
Collaborator

@terjekv terjekv commented Nov 29, 2023

  • Prevents the CLI from dying when confronted with commands like permission network_add 123.123.123.0/27 some-group-name ^[a-z0-9\-]+(\.(aa|bbb|ccc|sikkerhet?\.uio\.no$
  • To allow for reuse of exception formatting, moves the formatting to the exceptions themselves rather than leaving the issue for the user.

  - Prevents the CLI from dying when confronted with commands like `permission network_add 123.123.123.0/27 some-group-name ^[a-z0-9\-]+(\.(aa|bbb|ccc|sikkerhet?\.uio\.no$`
  - To allow for reuse of exception formatting, moves the formatting to the exceptions themselves rather than leaving the issue for the user.
@terjekv terjekv self-assigned this Nov 29, 2023
@terjekv terjekv requested review from oyvindhagberg and pederhan and removed request for oyvindhagberg November 29, 2023 12:18
Copy link
Member

@pederhan pederhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pederhan pederhan merged commit a7d33bc into unioslo:master Dec 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants