Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid applying filtering inside of quoted strings. #178

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Avoid applying filtering inside of quoted strings. #178

merged 2 commits into from
Nov 29, 2023

Conversation

terjekv
Copy link
Collaborator

@terjekv terjekv commented Nov 28, 2023

  • If a string is quoted, don't treat | as a filter command.
  • Handles and matches both " and '.

Fixes #177

@terjekv
Avoid applying filtering inside of quoted strings.
a765c85 
  - If a string is quoted, don't treat | as a filter command.
  - Handles and matches both " and '.

Fixes unioslo#177
@terjekv terjekv self-assigned this Nov 28, 2023
oyvindhagberg
oyvindhagberg approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@oyvindhagberg oyvindhagberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
See also: #179

@oyvindhagberg oyvindhagberg merged commit 71ec9c8 into unioslo:master Nov 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindhagberg oyvindhagberg oyvindhagberg approved these changes

@pederhan pederhan Awaiting requested review from pederhan

Assignees

@terjekv terjekv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter doesn't play nice with some commands
2 participants
@terjekv @oyvindhagberg