Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ucs01-relay): initial implementation #634

Merged
merged 4 commits into from
Sep 7, 2023
Merged

feat(ucs01-relay): initial implementation #634

merged 4 commits into from
Sep 7, 2023

Conversation

hussein-aitlahcen
Copy link
Contributor

@hussein-aitlahcen hussein-aitlahcen commented Sep 5, 2023 •
edited
Loading

towards #633 (EVM not touched yet)
towards completion of #150 (EVM not touched yet)

@hussein-aitlahcen hussein-aitlahcen force-pushed the 150-support-multi-denoms-in-cw20evm-ics20 branch 7 times, most recently from 1cba3dc to e95074e Compare September 7, 2023 12:02
@hussein-aitlahcen hussein-aitlahcen force-pushed the 150-support-multi-denoms-in-cw20evm-ics20 branch 2 times, most recently from 639e400 to 83baa08 Compare September 7, 2023 12:15
@hussein-aitlahcen hussein-aitlahcen force-pushed the 150-support-multi-denoms-in-cw20evm-ics20 branch from 83baa08 to 58c478b Compare September 7, 2023 12:15
@hussein-aitlahcen hussein-aitlahcen marked this pull request as ready for review September 7, 2023 13:22
aeryz
aeryz previously approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@aeryz aeryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like a solid API, and implementation, nice work!

cosmwasm/ucs01-relay-api/src/protocol.rs Outdated Show resolved Hide resolved
aeryz
aeryz previously approved these changes Sep 7, 2023
View reviewed changes
@hussein-aitlahcen hussein-aitlahcen force-pushed the 150-support-multi-denoms-in-cw20evm-ics20 branch from cfc3643 to a20d9e6 Compare September 7, 2023 14:20
aeryz
aeryz previously approved these changes Sep 7, 2023
View reviewed changes
benluelo
benluelo reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Documentation (both in-code and external) would be nice, but I'm assuming that'll come in future PRs

cosmwasm/ucs01-relay-api/src/protocol.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/protocol.rs Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/protocol.rs Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/protocol.rs Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/types.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/types.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay-api/src/types.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay/src/ibc.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay/src/protocol.rs Outdated Show resolved Hide resolved
cosmwasm/ucs01-relay/src/protocol.rs Show resolved Hide resolved
@hussein-aitlahcen hussein-aitlahcen force-pushed the 150-support-multi-denoms-in-cw20evm-ics20 branch from f80b01f to 3a35514 Compare September 7, 2023 16:29
@hussein-aitlahcen hussein-aitlahcen merged commit 8cca803 into main Sep 7, 2023
118 checks passed
@hussein-aitlahcen hussein-aitlahcen deleted the 150-support-multi-denoms-in-cw20evm-ics20 branch September 7, 2023 16:49
@aeryz aeryz mentioned this pull request Sep 11, 2023
Closed
@hussein-aitlahcen hussein-aitlahcen mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeryz aeryz aeryz left review comments

@benluelo benluelo benluelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussein-aitlahcen @aeryz @benluelo