Work around excessive stack depth error in TS 5.4 #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By treating the first type parameter of Zeros<> as a distributive conditional type, we defer its evaluation enough to avoid the error.
🦋 Changeset detectedLatest commit: b95279e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you, that looks good. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 44 44
Lines 242 242
Branches 52 52
=======================================
Hits 240 240
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
Note that there are some other types failing the test in 5.4. Will address them and cut a release on the v7 train. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to TypeScript 5.4 in my project and checking with
skipLibCheck: false, I started getting an excessive stack depth error that pointed at theMultiplytype. After digging into it, the problem actually seems to come fromZeros.By treating the first type parameter of
Zerosas a distributive conditional type, we defer its evaluation enough to avoid the error.