Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polars dtype test to generate more examples #1770

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

deepyaman
Copy link
Collaborator

@deepyaman deepyaman commented Aug 1, 2024

Otherwise, it's always testing all-null dataframes, as far as I can tell (see https://discord.com/channels/897120336003334214/1160076741394563102/1268358149400690719).

Also dropped the include_nulls keyword, which I don't think does anything (see pola-rs/polars#17969).

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (812b2a8) to head (a454729).
Report is 154 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   94.28%   93.31%   -0.97%     
==========================================
  Files          91      120      +29     
  Lines        7013     9129    +2116     
==========================================
+ Hits         6612     8519    +1907     
- Misses        401      610     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie
Copy link

FYI: I wouldn't necessarily drop include_nulls completely. Instead, I'd consider replacing it with the updated param allow_null=True:

allow_null : bool or Mapping[str, bool]
    Allow nulls as possible values and allow the `Null` data type by default.
    Accepts either a boolean or a mapping of column names to booleans.

@deepyaman
Copy link
Collaborator Author

FYI: I wouldn't necessarily drop include_nulls completely. Instead, I'd consider replacing it with the updated param allow_null=True:

allow_null : bool or Mapping[str, bool]
    Allow nulls as possible values and allow the `Null` data type by default.
    Accepts either a boolean or a mapping of column names to booleans.

Sorry, I missed this before; I'm OK either way, as the argument defaults to True anyway.

@cosmicBboy cosmicBboy merged commit 13bb3ce into unionai-oss:main Aug 16, 2024
179 of 180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants