-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static type hint error on class pandera DataFrame #1207
Conversation
thanks! sorry for this bit of process, but could you follow the steps here to get the DCO check to pass? |
…aFrame Signed-off-by: manel4 <[email protected]>
Signed-off-by: manel4 <[email protected]>
Done! I also added another commit to use the schema paratemer instead of the generic type. If it does not fit you, let me know. |
mypy doesn't seem to like this: https://github.com/unionai-oss/pandera/actions/runs/5134262937/jobs/9239769839?pr=1207 Feel free to |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 65 65
Lines 5067 5067
=======================================
Hits 4927 4927
Misses 140 140
☔ View full report in Codecov by Sentry. |
Signed-off-by: manel4 <[email protected]>
Hi, I have been trying to solve the mypy problem but I cannot come up with anything. It is weird, in pyright works: https://pyright-playground.decorator-factory.su/?gzip=H4sIAM1PeGQC_42QTQvCMAyG7_0VYacWdOCOA8We_APFy5ASZqaFrRttFPz37sup4MEcwkt48-SjCm0D_Oicv4BrujYwmEdHqzEfMazgQJ6CK6eKrh1GIQxsXwaZmESJssYYQcvZXJiTygX0caYKrHXesbUyUl3N9SHSNF30KPaRkV3ZEF_b89LOFHkjMR8nDmRY7yDRvUrerEB8Cx50gSep_qVmf1PNFxX783U67eU8KxHoTljb_o8kUYkPQ_bL8AQOuJLBdQEAAA%3D%3D whereas in mypy does not: https://mypy-play.net/?mypy=latest&python=3.11&flags=verbose&gist=3cb8319b768b1be2e91fbf77347c7a57 So I just added the type:ignore as commented by you. |
Signed-off-by: manel4 <[email protected]>
thanks, and congrats on your first contribution to pandera @manel-ab ! 🚀 |
thank you! |
I stated an error referencing this issue: https://github.com/unionai-oss/pandera/issues/1205.
As commented by @cosmicBboy, here is my solution.