Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: check for presence of default attribute before calling #1191

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Bugfix: check for presence of default attribute before calling #1191

merged 1 commit into from
Jun 1, 2023

Conversation

kykyi
Copy link
Contributor

@kykyi kykyi commented May 18, 2023

Fixes issue: 1188 by ensuring the .default attributes exists on the schema object before calling it.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f401617) 97.23% compared to head (2938aa4) 97.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files          65       65           
  Lines        5067     5067           
=======================================
  Hits         4927     4927           
  Misses        140      140           
Impacted Files Coverage Δ
pandera/backends/pandas/array.py 98.14% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cosmicBboy
Copy link
Collaborator

thanks for the fix @kykyi ! this project requires contributors to sign-off their commits according to the DCO standard: take a look here to sign off the commits of this PR.

@kykyi
Copy link
Contributor Author

kykyi commented May 22, 2023

thanks for the fix @kykyi ! this project requires contributors to sign-off their commits according to the DCO standard: take a look here to sign off the commits of this PR.

Apologies @cosmicBboy adding the -s into each commit command will require some muscle memory re-training 😆

I have updated my commit to have a sign-off 👌

@cosmicBboy cosmicBboy merged commit 53322e7 into unionai-oss:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants