Skip to content

Commit

Permalink
update pylint, fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
cosmicBboy committed Sep 1, 2021
1 parent aca7960 commit 6cdba35
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ repos:
args: ["--line-length=79"]

- repo: https://github.com/pycqa/pylint
rev: pylint-2.7.2
rev: v2.10.2
hooks:
- id: pylint
args: ["--disable=import-error"]
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _build_setup_requirements() -> Dict[str, List[Requirement]]:

def _build_dev_requirements() -> List[Requirement]:
"""Load requirements from file."""
with open(REQUIREMENT_PATH, "rt") as req_file:
with open(REQUIREMENT_PATH, "rt", encoding="utf-8") as req_file:
return list(parse_requirements(req_file.read()))


Expand Down
4 changes: 3 additions & 1 deletion tests/core/test_decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ def validate_inplace(df):
for out_schema in [1, 5.0, "foo", {"foo": "bar"}, ["foo"]]:

# mypy finds correctly the wrong usage
# pylint: disable=cell-var-from-loop
@check_io(out=out_schema) # type: ignore[arg-type]
def invalid_out_schema_type(df):
return df
Expand Down Expand Up @@ -688,7 +689,8 @@ def test_check_types_with_literal_type(arg_examples):
@check_types
def transform_with_literal(
df: DataFrame[InSchema],
arg: arg_type, # pylint: disable=unused-argument
# pylint: disable=unused-argument,cell-var-from-loop
arg: arg_type,
) -> DataFrame[OutSchema]:
return df.assign(b=100)

Expand Down

0 comments on commit 6cdba35

Please sign in to comment.