This repository has been archived by the owner on Nov 3, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just wanted to ask if the use of
page.screenshot
was intentional or if you would like to use theelementHandle.screenshot
method instead. (See puppeteer docs)I had to change it in my styleguidist project since puppeteer would always take a screenshot of the "props & methods" table after it triggered a click action on a button which toggled the components content.
Before changing the code to use
elementHandle.screenshot
I tried to set the--wait
option globally and also for the single click action but none helped. But after I changed the code to useelementHandle.screenshot
it worked really well.Best regards
Eric