Skip to content
This repository has been archived by the owner on Nov 3, 2019. It is now read-only.

Making use of elementHandle.screenshot #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theZieger
Copy link
Contributor

Hi,

I just wanted to ask if the use of page.screenshot was intentional or if you would like to use the elementHandle.screenshot method instead. (See puppeteer docs)

I had to change it in my styleguidist project since puppeteer would always take a screenshot of the "props & methods" table after it triggered a click action on a button which toggled the components content.

Before changing the code to use elementHandle.screenshot I tried to set the --wait option globally and also for the single click action but none helped. But after I changed the code to use elementHandle.screenshot it worked really well.

Best regards

Eric

@unindented
Copy link
Owner

@theZieger it was intentional cause we had issues with elementHandle.screenshot and scrolling in the past. We'll revisit, thanks for bringing it up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants