Add Zip static PIE build #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anindyasen
commented
Oct 9, 2022
anindyasen
commented
- Added zip application as a static-pie build
- A build.sh script is created to download, extract, patch and compile the application.
- rootfs, filesystem to store file in unikernel.
- Patch has the changes required in zip application to build it as static-pie.
StefanJum
requested changes
Oct 15, 2022
StefanJum
requested changes
Oct 20, 2022
StefanJum
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Thank you @anindyasen, hopefully these are the last comments, fix them and I will approve the pr 🚀
|
Looks good but please remove the |
Signed-off-by: anindya_sen <[email protected]>
StefanJum
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
All good now, thank you.
Reviewed-by: Stefan Jumarea [email protected]
StefanJum
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
All good now, thank you.
Reviewed-by: Stefan Jumarea [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.