Added apache to dynamic apps #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanJum
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Thank you @marianabtw, please add a README file, similar to this. Also see the inline comments.
Also copy the local /usr/lib/apache2/modules/ directory into ./etc/apache2/modules.
| # The directory where shm and other runtime files will be stored. | ||
| # | ||
|
|
||
| DefaultRuntimeDir ${APACHE_RUN_DIR} |
There was a problem hiding this comment.
Suggested change
| DefaultRuntimeDir ${APACHE_RUN_DIR} | |
| DefaultRuntimeDir /etc/apache-rundir |
You can hardcode the env variables into the config file.
Create an empty directory named /etc/apache-rundir so the server can start.
| # identification number when it starts. | ||
| # This needs to be set in /etc/apache2/envvars | ||
| # | ||
| PidFile ${APACHE_PID_FILE} |
There was a problem hiding this comment.
Suggested change
| PidFile ${APACHE_PID_FILE} | |
| PidFile <some-file> |
Same as above, add a filename here.
| # logged here. If you *do* define an error logfile for a <VirtualHost> | ||
| # container, that host's errors will be logged there and not here. | ||
| # | ||
| ErrorLog ${APACHE_LOG_DIR}/error.log |
There was a problem hiding this comment.
Suggested change
| ErrorLog ${APACHE_LOG_DIR}/error.log | |
| ErrorLog <...>/error.log |
Same as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.