Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nasm #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added nasm #75

wants to merge 1 commit into from

Conversation

sinamhdv
Copy link
Contributor

No description provided.

@razvand
Copy link
Contributor

razvand commented Sep 24, 2023

Thanks, @sinamhdv . Please format and sign off your commit according to Unikraft's contributor guidelines.

Please also add a README.md similar to the one for the http_server in C.

@sinamhdv sinamhdv force-pushed the add-nasm branch 2 times, most recently from df44702 to 0afd0e6 Compare September 24, 2023 20:11
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sinamhdv. See my comments.

nasm/README.md Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Show resolved Hide resolved
@razvand
Copy link
Contributor

razvand commented Sep 24, 2023

@sinamhdv , also add a line mentioning how to check everything worked OK:

objdump -D -b binary -m i386 -M intel sample_code

@razvand
Copy link
Contributor

razvand commented Sep 24, 2023

20 HP, 20 more when this is submitted

@razvand razvand self-assigned this Sep 24, 2023
@razvand razvand added the enhancement New feature or request label Sep 24, 2023
@sinamhdv sinamhdv force-pushed the add-nasm branch 2 times, most recently from 4b7edeb to 30419ca Compare September 24, 2023 21:18
@sinamhdv sinamhdv requested a review from razvand September 24, 2023 21:19
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
nasm/README.md Outdated Show resolved Hide resolved
added root directory, binary, and libraries for nasm to the dynamic-apps that can be run in bincompat mode.

Signed-off-by: Sina Mahdavi <[email protected]>
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message to:

Add Nasm (Netwide Assembler)

Add Nasm root directory.  It consists of the `nasm` binary, requried libraries and `README.md`. It is to be used with Unikraft in bincompat mode.

```console
objdump -D -b binary -m i386 -M intel,x86-64 sample_code
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra white line at the end.

@@ -0,0 +1,43 @@
# Netwide Assembler

This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft.
This is Nasm (_Netwide assembler_).
it is meant to be used in the binary compatibility mode of Unikraft.

- `lib/` & `lib64/`: the required libraries for Nasm

## Extract Dynamic Libraries

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording. Say: "Use the extract.sh script to extract the required dynamic libraries for the binary:"

../extract.sh usr/bin/nasm
```

output:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording.

```

## Run on Linux

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording.

```

## Run on Unikraft

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add wording.

@StefanJum StefanJum mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants