-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nasm #75
base: master
Are you sure you want to change the base?
added nasm #75
Conversation
Thanks, @sinamhdv . Please format and sign off your commit according to Unikraft's contributor guidelines. Please also add a |
df44702
to
0afd0e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sinamhdv. See my comments.
@sinamhdv , also add a line mentioning how to check everything worked OK:
|
20 HP, 20 more when this is submitted |
4b7edeb
to
30419ca
Compare
added root directory, binary, and libraries for nasm to the dynamic-apps that can be run in bincompat mode. Signed-off-by: Sina Mahdavi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message to:
Add Nasm (Netwide Assembler)
Add Nasm root directory. It consists of the `nasm` binary, requried libraries and `README.md`. It is to be used with Unikraft in bincompat mode.
```console | ||
objdump -D -b binary -m i386 -M intel,x86-64 sample_code | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra white line at the end.
@@ -0,0 +1,43 @@ | |||
# Netwide Assembler | |||
|
|||
This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the (Nasm) Netwide assembler and it is meant to be used in the binary compatibility mode of Unikraft. | |
This is Nasm (_Netwide assembler_). | |
it is meant to be used in the binary compatibility mode of Unikraft. |
- `lib/` & `lib64/`: the required libraries for Nasm | ||
|
||
## Extract Dynamic Libraries | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add wording. Say: "Use the extract.sh
script to extract the required dynamic libraries for the binary:"
../extract.sh usr/bin/nasm | ||
``` | ||
|
||
output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add wording.
``` | ||
|
||
## Run on Linux | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add wording.
``` | ||
|
||
## Run on Unikraft | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add wording.
No description provided.