-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/usage: Add build and run complex apps doc #147
docs/usage: Add build and run complex apps doc #147
Conversation
ff67f00
to
7ec2ce9
Compare
With the transition to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @mariasfiraiala, see my comments.
7ec2ce9
to
bf10ce6
Compare
Done @StefanJum! Take another tour when you find the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice @mariasfiraiala, thank you.
I will test the command in the next few days and come back with a new round.
bf10ce6
to
4ed4412
Compare
Great thing @StefanJum. I've also integrated your latest suggestions. Hope it looks alright now (Markdown wise). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mariasfiraiala, I tested the commands and everything works well.
See the few comments I left.
4ed4412
to
e364d45
Compare
I've committed your suggestions @StefanJum. Take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good besides the few comments, thanks @mariasfiraiala.
@razvand please take a quick look over this.
e364d45
to
0ea98ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks.
Reviewed-by: Stefan Jumarea [email protected]
Approved-by: Stefan Jumarea [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mariasfiraiala. This looks very good. See my minor comments.
I want to take another tour, to test the steps you mentioned and make sure everything is clear for future readers.
0ea98ff
to
a607c08
Compare
Done @razvand. Take another look, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mariasfiraiala, see my comments. Also use virbr0
as the bridge ID, instead of kraft0
, throughout the tutorial.
This commit adds documentation for building and running complex applications on `x86` and `AArch64`. It goes into detail regarding configuration steps and manual launch commands for the make build system. Signed-off-by: Maria Sfiraiala <[email protected]>
a607c08
to
816fbe1
Compare
Just integrated what you've suggested @razvand! Thanks for the time and take another look, please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mariasfiraiala.
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
This PR adds documentation for building and running complex applications on
x86
andAArch64
.It goes into detail regarding configuration steps and manual launch commands for the make build system.
Depends on having these PRs merged:
newlib
PRSigned-off-by: Maria Sfiraiala [email protected]