Fix command for manually running redis

[mariasfiraiala]

Signed-off-by: Maria Sfiraiala [email protected]

[razvand]

Hi, @mariasfiraiala . What is this useful for? I was able to run the Redis Unikraft application with the initial command.

Your version of the command is required only if the Redis application is built with 9pfs support when running:

make menuconfig

But 9pfs support is not required. Maybe there should be a fix in the documentation of lib-redis to point out that 9pfs support is not required (unlike lib-nginx - referenced there).

[mariasfiraiala]

Alright then, closing this PR. I'll take a look into the documentation for lib-redis.

[razvand]

Hi, @mariasfiraiala . Based on our discussion, this PR is indeed useful. We require a redis.conf configuration file to be passed to Redis, and that needs to be done via a filesystem (such as 9pfs).

Please update this commit with the fs0/redis.conf file.

This redis.conf file worked for me, maybe you can simplify it:

bind 172.44.0.2
port 6379
tcp-backlog 511
timeout 0
tcp-keepalive 300

[razvand]

Also add instructions on adding 9pfs support with the proper tag (rootfs in the command above), similar to the lib-nginx documentation. You could also add this to the lib-redis repository for consistency.

I think consistency is important, so I would aim to make Redis and Nginx as close to each other as possible, documentation-wise.

[StefanJum]

Only one comment, looks good besides that.

[mariasfiraiala]

Only one comment, looks good besides that.

Thank you @StefanJum . Removed it.

[StefanJum]

Few more comments.

[StefanJum]

One more little comment.

[StefanJum]

All good, thank you @mariasfiraiala.
Reviewed-by: Stefan Jumarea [email protected]

[razvand]

@mariasfiraiala , please mark solved items with Resolve conversation and re-request reviews from reviewers (@StefanJum in this case).

[razvand]

This works. Thanks, @mariasfiraiala

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]