Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

[app]/[redis]: [Removed extra instance of redis-tools] #21

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

[app]/[redis]: [Removed extra instance of redis-tools] #21

wants to merge 1 commit into from

Conversation

BJhutti
Copy link

@BJhutti BJhutti commented Sep 24, 2023 •
edited
Loading

Readme.md: Remove extra redis-tools from requirements

StefanJum
StefanJum reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Opsine02 redis-tools is needed in order to test the Redis application, which is why we added it in the requirements.

@BJhutti
Copy link
Author

BJhutti commented Sep 24, 2023 •
edited
Loading

there is an extra instance of redis tools in the README.md that i fixed in this pull request

image

StefanJum
StefanJum suggested changes Sep 24, 2023
View reviewed changes
Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, it's fine then, but please update the commit message to something more descriptive (e.g. Readme.md: Remove extra redis-tools` from requirements)

@StefanJum
Copy link
Member

@Opsine02 please also update the email address to your actual email address (not with the unikraft.org domain).

@BJhutti
Readme.md: Remove extra redis-tools from requirements
7b80ba1 
Removed an extra `redis-tools` located in the Requirments section of
`README.md`

Signed-off-by: Bryan Jhutti <[email protected]>
@BJhutti
Copy link
Author

BJhutti commented Sep 24, 2023

pushed again

@StefanJum StefanJum self-requested a review September 25, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StefanJum StefanJum Awaiting requested review from StefanJum

Assignees

@razvand razvand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BJhutti @StefanJum @razvand