You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.
The documentation for ServerConfig.PublicKeyCallback says that "A call to this function does not guarantee that the key offered is in fact used to authenticate." Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key. PublicKeyCallback may be called with multiple keys, and the order in which the keys were provided cannot be used to infer which key the client successfully authenticated with, if any. Some applications, which store the key(s) passed to PublicKeyCallback (or derived information) and make security relevant determinations based on it once the connection is established, may make incorrect assumptions.
For example, an attacker may send public keys A and B, and then authenticate with A. PublicKeyCallback would be called only twice, first with A and then with B. A vulnerable application may then make authorization decisions based on key B for which the attacker does not actually control the private key.
Since this API is widely misused, as a partial mitigation golang.org/x/[email protected] enforces the property that, when successfully authenticating via public key, the last key passed to ServerConfig.PublicKeyCallback will be the key used to authenticate the connection. PublicKeyCallback will now be called multiple times with the same key, if necessary. Note that the client may still not control the last key passed to PublicKeyCallback if the connection is then authenticated with a different method, such as PasswordCallback, KeyboardInteractiveCallback, or NoClientAuth.
Users should be using the Extensions field of the Permissions return value from the various authentication callbacks to record data associated with the authentication attempt instead of referencing external state. Once the connection is established the state corresponding to the successful authentication attempt can be retrieved via the ServerConn.Permissions field. Note that some third-party libraries misuse the Permissions type by sharing it across authentication attempts; users of third-party libraries should refer to the relevant projects for guidance.
An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing. This could cause a denial of service.
Unclear documentation of the error behavior in ParseWithClaims can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned by ParseWithClaims return both error codes. If users only check for the jwt.ErrTokenExpired using error.Is, they will ignore the embedded jwt.ErrTokenSignatureInvalid and thus potentially accept invalid tokens.
Fix
We have back-ported the error handling logic from the v5 branch to the v4 branch. In this logic, the ParseWithClaims function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release.
Workaround
We are aware that this changes the behaviour of an established function and is not 100 % backwards compatible, so updating to 4.5.1 might break your code. In case you cannot update to 4.5.0, please make sure that you are properly checking for all errors ("dangerous" ones first), so that you are not running in the case detailed above.
token, err:=/* jwt.Parse or similar */if token.Valid {
fmt.Println("You look nice today")
} elseiferrors.Is(err, jwt.ErrTokenMalformed) {
fmt.Println("That's not even a token")
} elseiferrors.Is(err, jwt.ErrTokenUnverifiable) {
fmt.Println("We could not verify this token")
} elseiferrors.Is(err, jwt.ErrTokenSignatureInvalid) {
fmt.Println("This token has an invalid signature")
} elseiferrors.Is(err, jwt.ErrTokenExpired) ||errors.Is(err, jwt.ErrTokenNotValidYet) {
// Token is either expired or not active yetfmt.Println("Timing is everything")
} else {
fmt.Println("Couldn't handle this token:", err)
}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.9.0->1.9.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
siderolabs/talos (siderolabs/talos)
v1.9.1Compare Source
Talos 1.9.1 (2024-12-26)
Welcome to the v1.9.1 release of Talos!
Please try out the release binaries and report any issues at
https://github.com/siderolabs/talos/issues.
Component Updates
Talos is built with Go 1.23.4.
Contributors
Changes
15 commits
348472frelease(v1.9.1): prepare releasee702542fix: ignore member not found error on leave cluster2125206test: use node informer instead of raw watch73c25eefix: talosctl support and race testsedd7844fix: update go-blockdevice to v2.0.9c1f975cfix: use correct default search domainff91a75fix: reduce installer image9cebe5efix: fixFailed to initialize SELinux labeling handleudev error852cf5afeat: bring Linux 6.12.6, CNI plugins 1.6.15f83c83docs: document Kubernetes service registry incompat with K8s 1.323f87286fix: dashboard crash on CPU dataf84ba2adocs: fix several typos972044echore: support gcr.io auth for cache and image gen7908c93fix: make talosctl time work with PTP time sync48cb3a6fix: restore previous disk serial fetchingChanges from siderolabs/go-talos-support
1 commit
0f784bdfix: avoid deadlock on context cancelChanges from siderolabs/pkgs
3 commits
45c4ba4fix: patch containerd with CNI deadlock fix13c5fc6feat: update Linux to 6.12.66ed389efeat: update Linux firmware to2024121Dependency Changes
Previous release can be found at v1.9.0
Images
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.