You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications and libraries which misuse the ServerConfig.PublicKeyCallback callback may be susceptible to an authorization bypass.
The documentation for ServerConfig.PublicKeyCallback says that "A call to this function does not guarantee that the key offered is in fact used to authenticate." Specifically, the SSH protocol allows clients to inquire about whether a public key is acceptable before proving control of the corresponding private key. PublicKeyCallback may be called with multiple keys, and the order in which the keys were provided cannot be used to infer which key the client successfully authenticated with, if any. Some applications, which store the key(s) passed to PublicKeyCallback (or derived information) and make security relevant determinations based on it once the connection is established, may make incorrect assumptions.
For example, an attacker may send public keys A and B, and then authenticate with A. PublicKeyCallback would be called only twice, first with A and then with B. A vulnerable application may then make authorization decisions based on key B for which the attacker does not actually control the private key.
Since this API is widely misused, as a partial mitigation golang.org/x/[email protected] enforces the property that, when successfully authenticating via public key, the last key passed to ServerConfig.PublicKeyCallback will be the key used to authenticate the connection. PublicKeyCallback will now be called multiple times with the same key, if necessary. Note that the client may still not control the last key passed to PublicKeyCallback if the connection is then authenticated with a different method, such as PasswordCallback, KeyboardInteractiveCallback, or NoClientAuth.
Users should be using the Extensions field of the Permissions return value from the various authentication callbacks to record data associated with the authentication attempt instead of referencing external state. Once the connection is established the state corresponding to the successful authentication attempt can be retrieved via the ServerConn.Permissions field. Note that some third-party libraries misuse the Permissions type by sharing it across authentication attempts; users of third-party libraries should refer to the relevant projects for guidance.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.21.2->8.21.3Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
gitleaks/gitleaks (gitleaks/gitleaks)
v8.21.3Compare Source
Changelog
a9e6d8cgo mod 1.232f73a3eEnsure keywords are downcased (#1633)f696605feat: add settlemint api keys detection (#1663)0bf13fcfeat(dir): better chunking (#1665)83e99bafeat(report): allow user-defined templates (#1650)e393d29Add support for GitLab routable tokens (#1656)263ce82Add freemius secret key detection (#1611)3c0e068fix(kubernetes): only match 'kind: secret' (#1649)f3adda0feat: use STDOUT when report file not specified (#1642)ed205a5fix(dir): skip opening file&dir if allowlist matches (#1653)6018012fix: increase chunk size 10kb -> 100kb (#1652)7f77987feat: detect sentry.io tokens in the new format (#1640)48a2e0erefactor: pre-commit hooks (#1627)4e303d0fix(easypost): only detect tokens of correct length (#1628)c1add1dfeat(dir): continue on permission error (#1621)202106aAdd human readable description for curl rules (#1625)8e94f98Add option to includeLinefield in report (#1616)dbb42a7hm (great comment)2599460Update README.md8ffb980nop for stupid build4181ad6Add new jira api token pattern (#1601)48ea14bfeat: update global & generic allowlist (#1618)81f0002fix(vault-service-token): ensure that TPS contains digits (#1614)c11adc9Generate comprehensive secret samples (#1484)d1d9054fix(aws): detect token in url (#1615)5fe58bffix(rules): entropy, uppercase in samples (#1593)5c2e813feat: tweak rules (#1608)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.