Terraform 0.8.x compatibility updates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR aims to address #9 |
|
Is this ready for review? Are there other changes necessary outside this module? |
|
Yes @pickgr this is ready for review! Unfortunately, I do not have permission to assign reviewers to this PR. |
|
@cristobal23 I added some reviewers. |
yuhunglin
reviewed
Jan 11, 2017
| @@ -35,7 +35,7 @@ variable "region" { | |||
| } | |||
|
|
|||
| variable "subnets" { | |||
| tpye = "string" | |||
| type = "string" | |||
yuhunglin
reviewed
Jan 11, 2017
| @@ -51,7 +51,7 @@ variable "region" { | |||
| } | |||
|
|
|||
| variable "subnet" { | |||
| tpye = "string" | |||
| type = "string" | |||
|
Looks like these are mostly escape sequences within interpolation fixes. Might want to try to do a quick dry run with the new changes to make sure any other 0.8 upgrades weren't needed. @cristobal23 once you give the 👍 with the dry run we can also tag the commit with a patch version bump. |
|
👍 tested and performed dry-runs with terraform version 0.8.0, 0.8.1 and 0.8.2 |
|
This PR is blocked by 0.8.x updates to terraform-aws-asg |
yuhunglin
pushed a commit
that referenced
this pull request
Apr 5, 2018
Add configurable DNS configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update modules to use terraform 0.8.x syntax where backslashes are ignored in variable interpolation