Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to improve tests #37

Merged
merged 10 commits into from
Mar 24, 2022
Merged

Refactor to improve tests #37

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c172f92
Rewrite tests using vscode-jsonrpc
remcohaszing Mar 3, 2022
0ddd434
Rewrite more tests
remcohaszing Mar 9, 2022
1d843c9
Rewrite remaining test
remcohaszing Mar 13, 2022
e289ed0
Fix type coverage
remcohaszing Mar 13, 2022
21f9d27
Fix tests for Node 12
remcohaszing Mar 13, 2022
ec97739
Fix resolving paths in Windows
remcohaszing Mar 13, 2022
91acc86
Add test for formatting unsynchronized documents
remcohaszing Mar 14, 2022
440d511
Use vscode-languageserver-protocol for testing
remcohaszing Mar 23, 2022
3dc9ae1
Explain a document might be unsynchronized
remcohaszing Mar 23, 2022
4e7e25d
Add workaround for timing issue
remcohaszing Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,6 @@ export function configureUnifiedLanguageServer(
connection.onDocumentFormatting(async (event) => {
const document = documents.get(event.textDocument.uri)

// `vscode-languageserver` crashes for commands to format unopen documents.
/* c8 ignore next 3 */
remcohaszing marked this conversation as resolved.
Show resolved Hide resolved
if (!document) {
return
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"devDependencies": {
"@types/tape": "^4.0.0",
"c8": "^7.0.0",
"execa": "^6.0.0",
"prettier": "^2.0.0",
"remark-cli": "^10.0.0",
"remark-preset-wooorm": "^9.0.0",
"tape": "^5.0.0",
"type-coverage": "^2.0.0",
"typescript": "^4.0.0",
"unified": "^10.0.0",
"vscode-jsonrpc": "^6.0.0",
"xo": "^0.47.0"
},
"scripts": {
Expand Down
Loading