Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite contributors to teams #2

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Invite contributors to teams #2

merged 3 commits into from
Aug 27, 2019

Conversation

johno
Copy link
Member

@johno johno commented Feb 27, 2019

It'd be nice to add a "contributor" team to unified organizations which all contributors are invited to. There's precedent here with what Gatsby does and helps contributors receive a warm welcome to the community after getting a PR merged.


Rendered version

text/0000-contributor-team.md Outdated Show resolved Hide resolved
text/0000-contributor-team.md Show resolved Hide resolved
text/0000-contributor-team.md Outdated Show resolved Hide resolved
@wooorm
Copy link
Member

wooorm commented Feb 28, 2019

Good idea! Thanks @johno, and also great feedback @ChristianMurphy!

I think this would be really good. When I kicked inactive people of the orgs, most people understood, but there was one person who was a bit annoyed and suggested something along these lines.

I feel the more active contributors (aka members) should receive precedence in tooling. We can do it manually at first, but of course we should try to automate it!
And contributors in general should be moved, when possible, to members (mergers, releasers), if they are so inclined (we could outline that process somewhere).

Finally, this RFC does affect the core collective governance document: https://github.com/unifiedjs/governance

@wooorm
Copy link
Member

wooorm commented Jul 12, 2019

Some more follow up ideas / questions:

  • I think this new team (contributors) can have the triage role: https://github.com/unifiedjs/governance/issues/18
  • I think writers and releasers should be in members, respectively with the write and maintain roles
  • How does this affect emeritus members? Should we drop emeritus and instead use contributors? I like that because that you don’t “phase people out” to inactive, but instead remove some of the rights / security risks they’re not using?

@johno
Copy link
Member Author

johno commented Jul 31, 2019

I think this new team (contributors) can have the triage role: unifiedjs/governance#18

💯

How does this affect emeritus members? Should we drop emeritus and instead use contributors? I like that because that you don’t “phase people out” to inactive, but instead remove some of the rights / security risks they’re not using?

Yeah I'd guess that emeritus would become the contributor role. Same permissions apply.

@wooorm
Copy link
Member

wooorm commented Aug 1, 2019

github-tools and npm-tools brings us very close to being able to do this automatically. We only need a humans.yaml in /governance and people will get invites daily.

I do foresee problems with a selection procedure:

  • Who gets added? Someone that comments on a thread? Someone that fixes a typo? Someone that writes a PR without really understanding the problem?
  • Who decides to add them? The member that comments first? The person that merges? Idea: should a member comment with something like: “Hey, thanks for this contribution, would you like to join us as a collaborator?” When the person agrees, the member whips up a PR to add their details?
  • Do members get to vote / voice concerns?

Note: read/triage rights aren’t that dangerous.

Oh and last:

  • Do we need to remove people that are not at all active? Every half year? Every year? What does it bring unified that we have 300 inactive collaborators with read rights?
  • I’m interest on any insights about all of this from Gatsby folks!

@wooorm wooorm added 🏗 area/tools This affects tooling 💬 type/discussion This is a request for comments 🙆 yes/confirmed This is confirmed and ready to be worked on labels Aug 10, 2019
wooorm added a commit to unifiedjs/collective that referenced this pull request Aug 22, 2019
* Add changes proposed in unifiedjs/rfcs#2
* Remove draft status
* Remove things now described in `members.md` and `organizations.md`
* Refactor things

Related-to unifiedjs/rfcs#2.
Related-to GH-17.
Related-to GH-29.
@wooorm
Copy link
Member

wooorm commented Aug 24, 2019

Final comment period! It’s almost ready to be implemented as the governance docs are updated for it.

wooorm added a commit to unifiedjs/collective that referenced this pull request Aug 25, 2019
* Add changes proposed in unifiedjs/rfcs#2
* Remove draft status
* Remove things now described in `members.md` and `organizations.md`
* Refactor things

Related-to unifiedjs/rfcs#2.
Related-to GH-17.
Related-to GH-29.
Closes GH-31.

Reviewed-by: Merlijn Vos <[email protected]>
@wooorm wooorm changed the title Propose contributor team for unified orgs Invite contributors to teams Aug 27, 2019
@wooorm wooorm merged commit d3277bc into master Aug 27, 2019
@wooorm wooorm deleted the contributor-team branch August 27, 2019 08:29
@wooorm wooorm added 👩‍⚕ area/health This affects community 💪 phase/solved Post is done and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Aug 27, 2019
wooorm added a commit to unifiedjs/collective that referenced this pull request Aug 28, 2019
Related to unifiedjs/rfcs#2.
Related to GH-29.
Related to GH-31.
Related to GH-32.
wooorm added a commit to unifiedjs/github-tools that referenced this pull request Aug 28, 2019
wooorm added a commit to unifiedjs/npm-tools that referenced this pull request Aug 28, 2019
wooorm added a commit to unifiedjs/github-tools that referenced this pull request Aug 28, 2019
wooorm added a commit to unifiedjs/npm-tools that referenced this pull request Aug 28, 2019
wooorm added a commit that referenced this pull request Aug 28, 2019
Closes GH-3.
Related to GH-2.

Reviewed-by: Christian Murphy <[email protected]>
@wooorm wooorm added the 💪 phase/solved Post is done label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👩‍⚕ area/health This affects community 🏗 area/tools This affects tooling 💪 phase/solved Post is done 💬 type/discussion This is a request for comments
Development

Successfully merging this pull request may close these issues.

4 participants