Fix emulator detection #1966
Merged
Fix emulator detection #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build errors on macos are also present on the main branch. No idea about the crash for MINGW64, help would be appreciated! |
|
MINGW64 errors is just random crashing which I can’t reproduce locally.
macOS is probably due to system upgraded.
…________________________________
From: Duncan Ogilvie ***@***.***>
Sent: Monday, June 24, 2024 3:31:17 AM
To: unicorn-engine/unicorn ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [unicorn-engine/unicorn] Fix emulator detection (PR #1966)
The build errors on macos are also present on the main branch. No idea about the crash for MINGW64, help would be appreciated!
―
Reply to this email directly, view it on GitHub<#1966 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULO5L6GTEEJFAQX3RE63ZI4PALAVCNFSM6AAAAABJXSSZIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGI3TSMZVGU>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
I will fix CI before 2.1.0. Let this PR get in firstly. |
|
You code accidentally trigger a long-live known mingw bug causing random segfaults on Windows, which was finally fixed in a5fa548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
This fixes the
bswap axdetection as well as various other detections related to bad REX prefix handling. This bug is also still upstream in qemu, but they moved the code around quite a bit:https://github.com/qemu/qemu/blob/ffeddb979400b1580ad28acbee09b6f971c3912d/target/i386/tcg/decode-new.c.inc#L2561-L2570
There are two fixes here:
bswap axnow correctly setsaxto zero