Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Unicode 10 #56

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Upgrade to Unicode 10 #56

merged 1 commit into from
Oct 22, 2019

Conversation

rth
Copy link
Contributor

@rth rth commented May 15, 2019

Partially addresses #43 by first upgrading to Unicode 10.0 (from 9.0).

As mentioned in that issue,

We may want to update to Unicode 10 before that; that should be a straightforward regen of the tables IIRC.

which is what I have done here.

From http://www.unicode.org/versions/Unicode10.0.0/ release notes,

UAX # 29 Unicode Text Segmentation

Strengthened the recommendation to use tailorings based on CLDR rules and emoji properties, for improved segmentation behavior of emoji zwj sequences. Changed the derivation of the Word_Break property value ALetter to include a set of 35 phonetic modifiers, to prevent word boundaries between those characters and alphabetic letters.

So no code changes are necessary as these modifications are included in the updated tables data, if I understand it right ?

@rth rth mentioned this pull request May 15, 2019
@Manishearth
Copy link
Member

Generates locally too.

Thanks!

Would you like to look into upgrading to Unicode 11? 12 is a simple data upgrade from there.

@rth
Copy link
Contributor Author

rth commented May 15, 2019

Would you like to look into upgrading to Unicode 11?

I might look into it at some point in the future, but probably not right now. That why I thought that upgrading to 10.0 could be a start..

@Manishearth Manishearth merged commit 0e09a6b into unicode-rs:master Oct 22, 2019
@Manishearth
Copy link
Member

Oops forgot to merge this

Thanks!

@rth rth deleted the unicode-10 branch October 22, 2019 22:28
@rth
Copy link
Contributor Author

rth commented Oct 22, 2019

No worries, I forgot I made it. Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants