Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an invariant relating Vowel_Dependent to Alphabetic #570

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add an invariant relating Vowel_Dependent to Alphabetic #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion unicodetools/src/main/resources/org/unicode/text/UCD/UnicodeInvariantTest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,10 @@ Show [\u20b9]
# exceptions. Should such exceptions arise, they can be added to the definition of
# $nonAlphabeticBindus to avoid a failure on this test.
Let $nonAlphabeticBindus = []
[\p{InSc=Bindu} - $nonAlphabeticBindus - \p{Alphabetic}] = []
[\p{InSc=Bindu} - \p{Alphabetic}] = $nonAlphabeticBindus

Let $nonAlphabeticDependentVowels = [\N{ORIYA SIGN OVERLINE}\N{THAI CHARACTER MAITAIKHU}\N{LIMBU SIGN KEMPHRENG}\N{SHARADA VOWEL MODIFIER MARK}\N{SHARADA EXTRA SHORT VOWEL MARK}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this set come from? Did you just try to assert that dependent vowels should be Alphabetic, and you found that these ones are not?
Please say something about this set in the PR description.

FYI @Ken-Whistler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this set come from? Did you just try to assert that dependent vowels should be Alphabetic, and you found that these ones are not?

Yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a footnote in the PR description.

I hesitated to add an invariant that they are all diacritics. Maybe I should.

[\p{InSC=Vowel_Dependent} - \p{Alphabetic}] = $nonAlphabeticDependentVowels

##########################
# LineBreak property
Expand Down
Loading