Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some data structs to serde(borrow) #820

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

sffc
Copy link
Member

@sffc sffc commented Jun 24, 2021

Fixes #632
See #667

@codecov-commenter
Copy link

Codecov Report

Merging #820 (30bfea2) into main (2b7ca3b) will increase coverage by 0.11%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   75.34%   75.45%   +0.11%     
==========================================
  Files         197      193       -4     
  Lines       12563    12489      -74     
==========================================
- Hits         9466     9424      -42     
+ Misses       3097     3065      -32     
Impacted Files Coverage Δ
experimental/provider_static/src/lib.rs 3.84% <0.00%> (-0.16%) ⬇️
provider/cldr/src/transform/numbers/cldr_serde.rs 64.91% <0.00%> (ø)
provider/core/src/hello_world.rs 80.32% <ø> (ø)
components/decimal/src/format.rs 86.20% <66.66%> (+2.33%) ⬆️
...ider/cldr/src/transform/numbers/decimal_pattern.rs 83.17% <71.42%> (+5.59%) ⬆️
components/decimal/src/provider.rs 62.50% <80.00%> (-9.38%) ⬇️
provider/cldr/src/transform/numbers/mod.rs 79.48% <100.00%> (ø)
provider/testdata/src/paths.rs
provider/testdata/src/metadata.rs
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7ca3b...30bfea2. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 24, 2021

Pull Request Test Coverage Report for Build 048e5d9207516ff6820a930f20802261ba7acd8d-PR-820

  • 17 of 28 (60.71%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 75.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/decimal/src/format.rs 2 3 66.67%
components/decimal/src/provider.rs 8 10 80.0%
experimental/provider_static/src/lib.rs 0 2 0.0%
provider/cldr/src/transform/numbers/decimal_pattern.rs 5 7 71.43%
provider/cldr/src/transform/numbers/cldr_serde.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
components/decimal/src/provider.rs 1 62.5%
experimental/provider_static/src/lib.rs 1 3.85%
provider/cldr/src/transform/numbers/decimal_pattern.rs 1 83.18%
Totals Coverage Status
Change from base Build 2b7ca3bd55486daafbcf579d05243773e006ec89: 0.02%
Covered Lines: 9552
Relevant Lines: 12647

💛 - Coveralls

@sffc sffc marked this pull request as ready for review June 24, 2021 17:33
@sffc sffc requested a review from a team as a code owner June 24, 2021 17:33
@sffc sffc requested review from Manishearth and removed request for a team June 24, 2021 17:33
Manishearth
Manishearth previously approved these changes Jun 24, 2021
description = "Run clippy (this target is used locally, not on CI)"
category = "ICU4X Development"
command = "cargo"
args = ["clippy", "--all-targets", "--all-features", "--", "-D", "warnings", "-Aclippy::unknown-clippy-lints", "-Aclippy::field-reassign-with-default"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: there should be a comment here saying that this list must be kept in sync with the github action, and a comment there pointing here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no, we already have cargo clippy-all, this should just call cargo clippy-all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should not have mixed the cargo quick fix in the same PR. I moved it to #826.

Please re-review this PR only from the data perspective.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • Makefile.toml is no longer changed in the branch
  • tools/scripts/tidy.toml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc requested a review from Manishearth June 24, 2021 21:14
@sffc sffc mentioned this pull request Jun 24, 2021
@sffc sffc merged commit 7ea6728 into unicode-org:main Jun 24, 2021
@sffc sffc deleted the serde-borrow-part1 branch June 24, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICU4X data structs don't actually borrow any data
4 participants