-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some data structs to serde(borrow) #820
Conversation
Codecov Report
@@ Coverage Diff @@
## main #820 +/- ##
==========================================
+ Coverage 75.34% 75.45% +0.11%
==========================================
Files 197 193 -4
Lines 12563 12489 -74
==========================================
- Hits 9466 9424 -42
+ Misses 3097 3065 -32
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 048e5d9207516ff6820a930f20802261ba7acd8d-PR-820
💛 - Coveralls |
tools/scripts/tidy.toml
Outdated
description = "Run clippy (this target is used locally, not on CI)" | ||
category = "ICU4X Development" | ||
command = "cargo" | ||
args = ["clippy", "--all-targets", "--all-features", "--", "-D", "warnings", "-Aclippy::unknown-clippy-lints", "-Aclippy::field-reassign-with-default"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: there should be a comment here saying that this list must be kept in sync with the github action, and a comment there pointing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no, we already have cargo clippy-all
, this should just call cargo clippy-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should not have mixed the cargo quick
fix in the same PR. I moved it to #826.
Please re-review this PR only from the data perspective.
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Fixes #632
See #667