-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sections on zero-copy and exotic types to style guide #699
Conversation
Pull Request Test Coverage Report for Build b12ff3d821ff7e3b06e2023758668aa417d939b3-PR-699
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy all seems reasonable to me, but I would hold off landing this until we have real examples in the code using the new ZeroCopy machinery. It seems a little early to fully require this, without any examples landed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Blocked on #652 per @gregtatum's comment above. |
8972a42
Codecov Report
@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 74.18% 73.99% -0.20%
==========================================
Files 171 182 +11
Lines 10802 10870 +68
==========================================
+ Hits 8014 8043 +29
- Misses 2788 2827 +39
Continue to review full report at Codecov.
|
Fixes #523
See #652