Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locale macros to remove dependency on TinyStr #337

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix locale macros to remove dependency on TinyStr #337

merged 1 commit into from
Oct 13, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 13, 2020

I changed the raw format back to primitives in order to eliminate the tinystr lookup problem.

However, the proc macro still has problems:

  • Does not work if icu_locale is not in scope
  • Two crates instead of one

We will work on these problems in the context of #310.

@sffc sffc requested a review from zbraniecki October 13, 2020 06:50
@sffc sffc requested a review from nciric as a code owner October 13, 2020 06:50
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • components/locale/src/subtags/language.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@zbraniecki zbraniecki added this to the ICU4X 0.1 milestone Oct 13, 2020
@zbraniecki zbraniecki mentioned this pull request Oct 13, 2020
Closed
@sffc sffc merged commit cc50a71 into unicode-org:master Oct 13, 2020
@sffc sffc deleted the locale-macro-fixup branch October 13, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@nciric nciric Awaiting requested review from nciric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ICU4X 0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sffc @zbraniecki