Adds support for CldrJSONDataProvider for Dates (based on #256) #258

zbraniecki · 2020-09-20T19:21:59Z

This is my WIP on the CLDRJsonDataProvider on top of #256

This is waiting for resolution in #257 and on #256, so I'm going to start it as a draft here.

jira-pull-request-webhook · 2020-09-20T19:22:39Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

coveralls · 2020-09-20T19:27:26Z

Pull Request Test Coverage Report for Build 3995b250e6517cb5e9d0754cd12e1f8b0b899761-PR-258

0 of 0 changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+6.3%) to 89.211%

Files with Coverage Reduction	New Missed Lines	%
components/locale/src/langid.rs	5	0%

Totals
Change from base Build ab00f54f6ce0fd898a6f8a6d70e77a24926a3dcd:	6.3%
Covered Lines:	1662
Relevant Lines:	1863

💛 - Coveralls

sffc

Nice!

components/cldr-json-data-provider/src/transform/dates.rs

components/cldr-json-data-provider/src/reader.rs

components/cldr-json-data-provider/src/transform/dates.rs

jira-pull-request-webhook · 2020-09-21T18:01:52Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/reader.rs is different
components/cldr-json-data-provider/src/transform/dates.rs is different
components/data-provider/src/structs/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-21T18:09:47Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-21T18:17:00Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-21T20:46:32Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/reader.rs is different
components/cldr-json-data-provider/src/transform/dates.rs is different
components/cldr-json-data-provider/tests/testdata/cs-ca-gregorian.json is now changed in the branch
components/data-provider/src/structs/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

zbraniecki · 2020-09-21T20:47:24Z

I think this patch is ready for review!

components/cldr-json-data-provider/src/transform/dates.rs

sffc · 2020-09-21T21:30:17Z

Also re-run cargo fmt please

jira-pull-request-webhook · 2020-09-22T01:19:54Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-22T02:18:50Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different
components/data-provider/src/structs/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-22T02:30:14Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different
components/data-provider/src/structs/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-22T02:32:31Z

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-22T02:33:23Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook · 2020-09-22T02:40:20Z

Notice: the branch changed across the force-push!

components/data-provider/src/data_key.rs is no longer changed in the branch
components/data-provider/src/structs/dates.rs is no longer changed in the branch
components/data-provider/src/structs/mod.rs is no longer changed in the branch
components/data-provider/src/structs/plurals.rs is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc · 2020-09-22T02:37:18Z

components/cldr-json-data-provider/src/transform/dates.rs

+                        true
+                    }
+                }
+                matches_width(&self.abbreviated, &other.abbreviated) &&


Consider:

(other.abbreviated.is_none() || Some(self.abbreviated) == other.abbreviated)

sffc · 2020-09-22T02:45:49Z

components/cldr-json-data-provider/src/transform/dates.rs

+        .take_payload()
+        .unwrap();
+
+    println!("{:#?}", cs_dates);


What happens to println! in tests?

jira-pull-request-webhook · 2020-09-22T03:15:09Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/mod.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc · 2020-09-22T05:11:17Z

components/cldr-json-data-provider/src/transform/dates.rs

+
+        impl PartialEq<cldr_json::$name::StandAloneWidths> for cldr_json::$name::FormatWidths {
+            fn eq(&self, other: &cldr_json::$name::StandAloneWidths) -> bool {
+                other.abbreviated.is_none() || Some(&self.abbreviated) == other.abbreviated.as_ref() &&


I think you need some more () due to order of operations.

Can you add a test case for this behavior?

Thanks! I remodelled it to bring a bit more unaliasing via ability to skip widths based on if they differ in stand_alone, and added a unit test.

jira-pull-request-webhook · 2020-09-22T17:40:09Z

Notice: the branch changed across the force-push!

components/cldr-json-data-provider/src/transform/dates.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

* Add support for Dates to CLDRJsonDataProvider * Apply feedback * Add Dates to FsDataProviderExport

zbraniecki force-pushed the datetime-provider branch from e6431e1 to 3015c6d Compare September 20, 2020 19:22

zbraniecki mentioned this pull request Sep 20, 2020

ICU4X 0.1 #204

Closed

sffc reviewed Sep 21, 2020

View reviewed changes

zbraniecki force-pushed the datetime-provider branch from 3015c6d to f0d81bf Compare September 21, 2020 18:01

zbraniecki force-pushed the datetime-provider branch from f0d81bf to 6b5979b Compare September 21, 2020 18:09

zbraniecki force-pushed the datetime-provider branch from 6b5979b to 9265129 Compare September 21, 2020 18:16

zbraniecki self-assigned this Sep 21, 2020

zbraniecki added this to the ICU4X 0.1 milestone Sep 21, 2020

zbraniecki force-pushed the datetime-provider branch from 9265129 to 0504a44 Compare September 21, 2020 20:46

zbraniecki marked this pull request as ready for review September 21, 2020 20:47

zbraniecki requested a review from a team as a code owner September 21, 2020 20:47

zbraniecki requested a review from sffc September 21, 2020 20:47

sffc previously approved these changes Sep 21, 2020

View reviewed changes

components/cldr-json-data-provider/src/transform/dates.rs Outdated Show resolved Hide resolved

components/cldr-json-data-provider/src/transform/dates.rs Outdated Show resolved Hide resolved

zbraniecki dismissed sffc’s stale review via b71df0d September 22, 2020 01:19

zbraniecki force-pushed the datetime-provider branch from 0504a44 to b71df0d Compare September 22, 2020 01:19

zbraniecki force-pushed the datetime-provider branch from b71df0d to 6777794 Compare September 22, 2020 02:18

zbraniecki force-pushed the datetime-provider branch from 6777794 to c35e5e8 Compare September 22, 2020 02:30

zbraniecki changed the title ~~[WIP] Adds support for CldrJSONDataProvider for Dates (based on #256)~~ Adds support for CldrJSONDataProvider for Dates (based on #256) Sep 22, 2020

zbraniecki force-pushed the datetime-provider branch from c35e5e8 to a0e6928 Compare September 22, 2020 02:32

zbraniecki force-pushed the datetime-provider branch from a0e6928 to 929674d Compare September 22, 2020 02:33

zbraniecki mentioned this pull request Sep 22, 2020

Adds Dates support for FsDataProviderExport (based on #258) #261

Merged

Add support for Dates to CLDRJsonDataProvider

81a49a0

zbraniecki force-pushed the datetime-provider branch from 929674d to 81a49a0 Compare September 22, 2020 02:40

sffc previously approved these changes Sep 22, 2020

View reviewed changes

zbraniecki dismissed sffc’s stale review via 7f05668 September 22, 2020 02:53

zbraniecki requested a review from sffc September 22, 2020 02:56

zbraniecki force-pushed the datetime-provider branch from 7f05668 to f9f693a Compare September 22, 2020 03:15

sffc reviewed Sep 22, 2020

View reviewed changes

Apply feedback

7bef1db

zbraniecki force-pushed the datetime-provider branch from f9f693a to 7bef1db Compare September 22, 2020 17:40

zbraniecki requested a review from sffc September 22, 2020 17:44

sffc approved these changes Sep 23, 2020

View reviewed changes

zbraniecki merged commit 97e53be into unicode-org:master Sep 23, 2020

zbraniecki added a commit that referenced this pull request Sep 23, 2020

Adds Dates support for FsDataProviderExport (based on #258) (#261)

2a4da75

* Add support for Dates to CLDRJsonDataProvider * Apply feedback * Add Dates to FsDataProviderExport

sffc linked an issue Oct 3, 2020 that may be closed by this pull request

CLDR to ICU4X-JSON Converter #177

Closed

zbraniecki deleted the datetime-provider branch October 19, 2020 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds support for CldrJSONDataProvider for Dates (based on #256) #258

Adds support for CldrJSONDataProvider for Dates (based on #256) #258

zbraniecki commented Sep 20, 2020

jira-pull-request-webhook bot commented Sep 20, 2020

coveralls commented Sep 20, 2020 •

edited

Loading

sffc left a comment

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

zbraniecki commented Sep 21, 2020

sffc commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

sffc Sep 22, 2020

zbraniecki Sep 22, 2020

sffc Sep 22, 2020

zbraniecki Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

sffc Sep 22, 2020

zbraniecki Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

Adds support for CldrJSONDataProvider for Dates (based on #256) #258

Adds support for CldrJSONDataProvider for Dates (based on #256) #258

Conversation

zbraniecki commented Sep 20, 2020

jira-pull-request-webhook bot commented Sep 20, 2020

coveralls commented Sep 20, 2020 • edited Loading

Pull Request Test Coverage Report for Build 3995b250e6517cb5e9d0754cd12e1f8b0b899761-PR-258

💛 - Coveralls

sffc left a comment

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 21, 2020

zbraniecki commented Sep 21, 2020

sffc commented Sep 21, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

jira-pull-request-webhook bot commented Sep 22, 2020

sffc Sep 22, 2020

Choose a reason for hiding this comment

zbraniecki Sep 22, 2020

Choose a reason for hiding this comment

sffc Sep 22, 2020

Choose a reason for hiding this comment

zbraniecki Sep 22, 2020

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented Sep 22, 2020

sffc Sep 22, 2020

Choose a reason for hiding this comment

zbraniecki Sep 22, 2020

Choose a reason for hiding this comment

jira-pull-request-webhook bot commented Sep 22, 2020

coveralls commented Sep 20, 2020 •

edited

Loading