Add ZeroVec::iter_mut() #1128
Merged
Add ZeroVec::iter_mut() #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I elected to not make |
zbraniecki
previously approved these changes
Sep 30, 2021
sffc
requested changes
Sep 30, 2021
utils/zerovec/src/zerovec/mod.rs
Outdated
Comment on lines
441
to
443
| let mut aligned = T::from_unaligned(item); | ||
| f(&mut aligned); | ||
| *item = aligned.as_unaligned() |
There was a problem hiding this comment.
Optional: maybe
*item = f(T::from_unaligned(item)).as_unaligned();
where the function returns a value rather than mutating the input?
There was a problem hiding this comment.
IME it's more ergonomic to work with mutables in closure rather than having to figure out how to return things
There was a problem hiding this comment.
Also I'm matching Iterator::for_each()'s signature
sffc
reviewed
Sep 30, 2021
| /// })?; | ||
| /// | ||
| /// assert_eq!(zerovec.to_vec(), &[212, 282, 422, 462]); | ||
| /// # Ok::<(), ()>(()) |
There was a problem hiding this comment.
what is this line for? Is this to make the ? operator work?
There was a problem hiding this comment.
Yes. It's not shown in the docs, just makes the doctest run
Co-authored-by: Shane F. Carr <[email protected]>
sffc
reviewed
Sep 30, 2021
sffc
approved these changes
Sep 30, 2021
robertbastian
pushed a commit
to robertbastian/icu4x
that referenced
this pull request
Oct 4, 2021
* Add ZeroVec::iter_mut() * Add ZeroVec::for_each_mut() * Expose make_mut, remove iter_mut, expose try_for_each_mut * Update utils/zerovec/src/zerovec/mod.rs Co-authored-by: Shane F. Carr <[email protected]> * apply suggestion * make_mut -> to_mut * fix Co-authored-by: Shane F. Carr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.