Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22721 Ignore CIFuzz spawned job and set delay for CI enforce checks job #3160

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Sep 12, 2024

CIFuzz jobs take a while to start. Until they do, within a workflow run, their neutral status and warning about "can't find configs" was causing the enforce-all-checks jobs to falsely fail.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22721
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu
Copy link
Member

The change looks fine, but the "docs minor fixes" ticket does not seem appropriate. Which ticket did you use for adding this check?

@echeran echeran changed the title ICU-22722 Set delay for CI enforce checks job to allow other jobs to init ICU-22721 Set delay for CI enforce checks job to allow other jobs to init Sep 12, 2024
echeran added a commit to echeran/icu that referenced this pull request Sep 12, 2024
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

srl295
srl295 previously approved these changes Sep 12, 2024
@echeran
Copy link
Contributor Author

echeran commented Sep 12, 2024

The change looks fine, but the "docs minor fixes" ticket does not seem appropriate. Which ticket did you use for adding this check?

PR #3055 used the other release ticket, so I will now reuse that instead.

On further inspection with @FrankYFTang, I think the cause is different than what I identified. It looks like the CIFuzz Github Action is spawning another job (ex: a cleanup job? a reporting job?) every time a CIFuzz job finishes. That's what's interfering with our enforce-all-checks job. We can add it to the ignore list in the enforce-all-checks config. There's nothing wrong with setting up a delay of 2 minutes, but adding ClusterFuzzLite/CIFuzz to the ignorelist might solve the real problem.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/wait-for-checks.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran merged commit 33a788b into unicode-org:main Sep 12, 2024
101 checks passed
@echeran echeran deleted the delay-enforce-checks branch September 12, 2024 22:18
@echeran echeran changed the title ICU-22721 Set delay for CI enforce checks job to allow other jobs to init ICU-22721 Ignore CIFuzz spawned job and set delay for CI enforce checks job Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants