-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22323 Typo fixes in docs for ICU TimeZone Classes #2674
Conversation
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Hi @spacegaier , the Jira ticket is for the soon-to-be-released version 74. We're in the process of vetting the release candidate version that we tagged before the final cut (GA = General Availability) of ICU 74. Instead of having you change the PR preamble to use a ticket for ICU 75 and change the commit message, we changed the target branch of your PR to the ICU 74 branch. The consequence of changing the PR target branch in Github is that the implicit
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@echeran Took a few attempts but in the end it worked. For some reason the VS Code terminal would not let me do the force push ("error: failed to push some refs to 'https://github.com/spacegaier/icu.git'"), but Github Desktop's force push from the GUI menu worked for some reason 😄 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Note: I am not sure if doc PRs also require the creation of a JIRA issue. If yes, let me know and I can do that as well and adjust the commit message.
Update: Looks like the CLI is requiring that. Is there a generic JIRA document fix ticket that can be referenced?
Final Update: I found another PR was the author was advised to reference ICU-22323 so I did the same now.
Checklist